-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A: Sites Dashboard - Fix last site item (row) in the table being cut off #89644
A4A: Sites Dashboard - Fix last site item (row) in the table being cut off #89644
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up on this!
Works well in the main sites dashboard view (no preview pane open).
If you open the preview pane whilst pagination is in place, the sites list is still getting chopped off (I don't see the last result when paginating by 10 for example).
Nice catch! Fixed in d96047f. |
As we've discussed, we will eventually have to fix the issue with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well now with the preview pane open!
Related to https://github.com/Automattic/automattic-for-agencies-dev/issues/299
Proposed Changes
Testing Instructions
For the below testing steps, make sure to run
yarn start-a8c-for-agencies
locally and then visithttp://agencies.localhost:3000/sites
.Before
After
Pre-merge Checklist