Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Sites Dashboard - Fix last site item (row) in the table being cut off #89644

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

gogdzl
Copy link
Contributor

@gogdzl gogdzl commented Apr 18, 2024

Related to https://github.com/Automattic/automattic-for-agencies-dev/issues/299

Proposed Changes

  • This PR adjusts the margin for the site dashboard table. Our previous margin setting did not account for the pagination's bottom bar.

Testing Instructions

For the below testing steps, make sure to run yarn start-a8c-for-agencies locally and then visit http://agencies.localhost:3000/sites.

  • To test, add a sufficient number of sites to trigger pagination while simultaneously filling the entire window.
  • Verify that the last site is not being cut off.

Before
image

After
image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gogdzl gogdzl requested review from cleacos and a team April 18, 2024 03:11
@gogdzl gogdzl self-assigned this Apr 18, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 18, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@coder-karen coder-karen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this!

Works well in the main sites dashboard view (no preview pane open).

If you open the preview pane whilst pagination is in place, the sites list is still getting chopped off (I don't see the last result when paginating by 10 for example).

@gogdzl
Copy link
Contributor Author

gogdzl commented Apr 18, 2024

If you open the preview pane whilst pagination is in place, the sites list is still getting chopped off (I don't see the last result when paginating by 10 for example).

Nice catch! Fixed in d96047f.

@coder-karen

@gogdzl gogdzl requested a review from coder-karen April 18, 2024 18:04
@cleacos
Copy link
Contributor

cleacos commented Apr 19, 2024

As we've discussed, we will eventually have to fix the issue with the height and vertical scrolling. It seems tricky, but maybe @keoshi, as a CSS expert, could know how to fix it.

Copy link
Contributor

@coder-karen coder-karen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well now with the preview pane open!

@gogdzl gogdzl merged commit f479abe into trunk Apr 19, 2024
11 checks passed
@gogdzl gogdzl deleted the fix/a4a/299-sites-dashboard-last-site-is-cut-off branch April 19, 2024 12:12
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants